Merge in the first bits of the API work
The catalyst-action-rest branch from shlevy/hydra was an exploration of using Catalyst::Action::REST to create a JSON API for hydra. This commit merges in the best bits from that experiment, with the goal that further API endpoints can be added incrementally. In addition to migrating more endpoints, there is potential for improvement in what's already been done: * The web interface can be updated to use the same non-GET endpoints as the JSON interface (using x-tunneled-method) instead of having a separate endpoint * The web rendering should use the $c->stash->{resource} data structure where applicable rather than putting the same data in two places in the stash * Which columns to render for each endpoint is a completely debatable question * Hydra::Component::ToJSON should turn has_many relations that have strings as their primary keys into objects instead of arrays Fixes NixOS/hydra#98 Signed-off-by: Shea Levy <shea@shealevy.com>
This commit is contained in:
@ -101,7 +101,7 @@ sub latest : Chained('get_builds') PathPart('latest') {
|
||||
|
||||
notFound($c, "There is no successful build to redirect to.") unless defined $latest;
|
||||
|
||||
$c->res->redirect($c->uri_for($c->controller('Build')->action_for("view_build"), [$latest->id], @rest));
|
||||
$c->res->redirect($c->uri_for($c->controller('Build')->action_for("build"), [$latest->id], @rest));
|
||||
}
|
||||
|
||||
|
||||
@ -116,7 +116,7 @@ sub latest_for : Chained('get_builds') PathPart('latest-for') {
|
||||
|
||||
notFound($c, "There is no successful build for platform `$system' to redirect to.") unless defined $latest;
|
||||
|
||||
$c->res->redirect($c->uri_for($c->controller('Build')->action_for("view_build"), [$latest->id], @rest));
|
||||
$c->res->redirect($c->uri_for($c->controller('Build')->action_for("build"), [$latest->id], @rest));
|
||||
}
|
||||
|
||||
|
||||
|
@ -2,7 +2,7 @@ package Hydra::Base::Controller::NixChannel;
|
||||
|
||||
use strict;
|
||||
use warnings;
|
||||
use base 'Catalyst::Controller';
|
||||
use base 'Hydra::Base::Controller::REST';
|
||||
use List::MoreUtils qw(all);
|
||||
use Nix::Store;
|
||||
use Hydra::Helper::Nix;
|
||||
|
18
src/lib/Hydra/Base/Controller/REST.pm
Normal file
18
src/lib/Hydra/Base/Controller/REST.pm
Normal file
@ -0,0 +1,18 @@
|
||||
package Hydra::Base::Controller::REST;
|
||||
|
||||
use strict;
|
||||
use warnings;
|
||||
use base 'Catalyst::Controller::REST';
|
||||
|
||||
__PACKAGE__->config(
|
||||
map => {
|
||||
'text/html' => [ 'View', 'TT' ]
|
||||
},
|
||||
default => 'text/html',
|
||||
'stash_key' => 'resource',
|
||||
);
|
||||
|
||||
sub begin { my ( $self, $c ) = @_; $c->forward('Hydra::Controller::Root::begin'); }
|
||||
sub end { my ( $self, $c ) = @_; $c->forward('Hydra::Controller::Root::end'); }
|
||||
|
||||
1;
|
Reference in New Issue
Block a user