ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

perlcritic: don't open files as bare words

Browse Source
This commit is contained in:
Graham Christensen
2021-09-06 22:19:00 -04:00
parent efd1d78b97
commit 21e1ff0da1
5 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/lib/Hydra/Helper/Nix.pm
View File

@ -141,8 +141,8 @@ sub registerRoot {
my ($path) = @_;
my $link = gcRootFor $path;
return if -e $link;
open ROOT, ">$link" or die "cannot create GC root `$link' to `$path'";
close ROOT;
open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";
close $root;
}
@ -341,8 +341,8 @@ sub getMachines {
for my $machinesFile (@machinesFiles) {
next unless -e $machinesFile;
open CONF, "<$machinesFile" or die;
while (<CONF>) {
open my $conf, "<$machinesFile" or die;
while (<$conf>) {
chomp;
s/\#.*$//g;
next if /^\s*$/;
@ -358,7 +358,7 @@ sub getMachines {
, mandatoryFeatures => [ @mandatoryFeatures ]
};
}
close CONF;
close $conf;
}
return \%machines;

6
src/lib/Hydra/Plugin/CoverityScan.pm
View File

@ -52,12 +52,12 @@ sub buildFinished {
my $tarballs = "$storePath/tarballs";
my $covTarball;
opendir TARBALLS, $tarballs or die;
while (readdir TARBALLS) {
opendir my $tarballs_handle, $tarballs or die;
while (readdir $tarballshandle) {
next unless $_ =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;
$covTarball = "$tarballs/$_"; last;
}
closedir TARBALLS;
closedir $tarballs_handle;
unless (defined $covTarball) {
print STDERR "CoverityScan.pm: Coverity tarball not found in $tarballs; skipping upload...\n";