Merge pull request #1003 from DeterminateSystems/perlcritic-level-4

perlcritic: level 4

src/lib/Hydra/Config.pm

@@ -1,5 +1,8 @@
 package Hydra::Config;
 
+use strict;
+use warnings;
+
 our %configGeneralOpts = (-UseApacheInclude => 1, -IncludeAgain => 1, -IncludeRelative => 1);
 
 1;

src/lib/Hydra/Controller/API.pm

@@ -8,11 +8,10 @@ use Hydra::Helper::Nix;
 use Hydra::Helper::CatalystUtils;
 use Hydra::Controller::Project;
 use JSON;
-use JSON::Any;
+use JSON::MaybeXS;
 use DateTime;
 use Digest::SHA qw(sha256_hex);
 use Text::Diff;
-use File::Slurp;
 use IPC::Run qw(run);
 
 
@@ -67,7 +66,7 @@ sub latestbuilds : Chained('api') PathPart('latestbuilds') Args(0) {
     push @list, buildToHash($_) foreach @latest;
 
     $c->stash->{'plain'} = {
-        data => scalar (JSON::Any->objToJson(\@list))
+        data => scalar (encode_json(\@list))
     };
     $c->forward('Hydra::View::Plain');
 }
@@ -108,7 +107,7 @@ sub jobsets : Chained('api') PathPart('jobsets') Args(0) {
     push @list, jobsetToHash($_) foreach @jobsets;
 
     $c->stash->{'plain'} = {
-        data => scalar (JSON::Any->objToJson(\@list))
+        data => scalar (encode_json(\@list))
     };
     $c->forward('Hydra::View::Plain');
 }
@@ -126,7 +125,7 @@ sub queue : Chained('api') PathPart('queue') Args(0) {
     push @list, buildToHash($_) foreach @builds;
 
     $c->stash->{'plain'} = {
-        data => scalar (JSON::Any->objToJson(\@list))
+        data => scalar (encode_json(\@list))
     };
     $c->forward('Hydra::View::Plain');
 }
@@ -170,7 +169,7 @@ sub nrbuilds : Chained('api') PathPart('nrbuilds') Args(0) {
     @arr = reverse(@arr);
 
     $c->stash->{'plain'} = {
-        data => scalar (JSON::Any->objToJson(\@arr))
+        data => scalar (encode_json(\@arr))
     };
     $c->forward('Hydra::View::Plain');
 }

src/lib/Hydra/Controller/Build.pm

@@ -8,7 +8,6 @@ use Hydra::Helper::Nix;
 use Hydra::Helper::CatalystUtils;
 use File::Basename;
 use File::stat;
-use File::Slurp;
 use Data::Dump qw(dump);
 use Nix::Store;
 use Nix::Config;

src/lib/Hydra/Controller/Job.pm

@@ -6,6 +6,7 @@ use warnings;
 use base 'Hydra::Base::Controller::ListBuilds';
 use Hydra::Helper::Nix;
 use Hydra::Helper::CatalystUtils;
+use JSON::MaybeXS;
 use Net::Prometheus;
 
 sub job : Chained('/') PathPart('job') CaptureArgs(3) {
@@ -50,7 +51,7 @@ sub shield :Chained('job') PathPart('shield') Args(0) {
 
     $c->response->content_type('application/json');
     $c->stash->{'plain'} = {
-        data => scalar (JSON::Any->objToJson(
+        data => scalar (encode_json(
             {
                 schemaVersion => 1,
                 label => "hydra build",

src/lib/Hydra/Controller/User.pm

@@ -4,7 +4,7 @@ use utf8;
 use strict;
 use warnings;
 use base 'Hydra::Base::Controller::REST';
-use File::Slurp;
+use File::Slurper qw(read_text);
 use Crypt::RandPasswd;
 use Digest::SHA1 qw(sha1_hex);
 use Hydra::Helper::Nix;
@@ -165,7 +165,7 @@ sub github_login :Path('/github-login') Args(0) {
     my $client_id = $c->config->{github_client_id} or die "github_client_id not configured.";
     my $client_secret = $c->config->{github_client_secret} // do {
         my $client_secret_file = $c->config->{github_client_secret_file} or die "github_client_secret nor github_client_secret_file is configured.";
-        my $client_secret = read_file($client_secret_file);
+        my $client_secret = read_text($client_secret_file);
         $client_secret =~ s/\s+//;
         $client_secret;
     };

src/lib/Hydra/Event.pm

@@ -1,6 +1,7 @@
 package Hydra::Event;
 
 use strict;
+use warnings;
 use Hydra::Event::BuildFinished;
 use Hydra::Event::BuildStarted;
 use Hydra::Event::StepFinished;

src/lib/Hydra/Helper/AddBuilds.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::AddBuilds;
 
 use strict;
+use warnings;
 use utf8;
 use Encode;
 use JSON;
@@ -14,7 +15,6 @@ use File::stat;
 use File::Path;
 use File::Temp;
 use File::Spec;
-use File::Slurp;
 use Hydra::Helper::CatalystUtils;
 
 our @ISA = qw(Exporter);

src/lib/Hydra/Helper/CatalystUtils.pm

@@ -2,6 +2,7 @@ package Hydra::Helper::CatalystUtils;
 
 use utf8;
 use strict;
+use warnings;
 use Exporter;
 use Readonly;
 use Nix::Store;

src/lib/Hydra/Helper/Email.pm

@@ -1,10 +1,10 @@
 package Hydra::Helper::Email;
 
 use strict;
+use warnings;
 use Email::MIME;
 use Email::Sender::Simple qw(sendmail);
 use Exporter 'import';
-use File::Slurp;
 use Hydra::Helper::Nix;
 use Sys::Hostname::Long;
 

src/lib/Hydra/Helper/Escape.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::Escape;
 
 use strict;
+use warnings;
 use base qw(Exporter);
 use Hydra::Helper::AttributeSet;
 

src/lib/Hydra/Helper/Nix.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::Nix;
 
 use strict;
+use warnings;
 use Exporter;
 use File::Path;
 use File::Basename;
@@ -65,8 +66,8 @@ sub getStatsdConfig {
     my %statsd = defined $cfg ? ref $cfg eq "HASH" ? %$cfg : ($cfg) : ();
 
     return {
-        "host" => %statsd{'host'}  // 'localhost',
-        "port" => %statsd{'port'}  // 8125,
+        "host" => $statsd{'host'}  // 'localhost',
+        "port" => $statsd{'port'}  // 8125,
     }
 }
 
@@ -83,20 +84,20 @@ sub getHydraNotifyPrometheusConfig {
         return undef;
     }
 
-    my $cfg = $cfg->{prometheus};
-    if (!defined($cfg)) {
+    my $promcfg = $cfg->{prometheus};
+    if (!defined($promcfg)) {
         return undef;
     }
 
-    if (ref $cfg ne "HASH") {
+    if (ref $promcfg ne "HASH") {
         print STDERR "Error reading Hydra's configuration file: hydra_notify.prometheus should be a block.\n";
         return undef;
     }
 
-    if (defined($cfg->{"listen_address"}) && defined($cfg->{"port"})) {
+    if (defined($promcfg->{"listen_address"}) && defined($promcfg->{"port"})) {
         return {
-            "listen_address" => $cfg->{'listen_address'},
-            "port" => $cfg->{'port'},
+            "listen_address" => $promcfg->{'listen_address'},
+            "port" => $promcfg->{'port'},
         };
     } else {
         print STDERR "Error reading Hydra's configuration file: hydra_notify.prometheus should include listen_address and port.\n";
@@ -140,8 +141,8 @@ sub registerRoot {
     my ($path) = @_;
     my $link = gcRootFor $path;
     return if -e $link;
-    open ROOT, ">$link" or die "cannot create GC root `$link' to `$path'";
-    close ROOT;
+    open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";
+    close $root;
 }
 
 
@@ -305,7 +306,8 @@ sub getEvals {
             { order_by => "id DESC", rows => 1 });
 
         my $curInfo = getEvalInfo($cache, $curEval);
-        my $prevInfo = getEvalInfo($cache, $prevEval) if defined $prevEval;
+        my $prevInfo;
+        $prevInfo = getEvalInfo($cache, $prevEval) if defined $prevEval;
 
         # Compute what inputs changed between each eval.
         my @changedInputs;
@@ -340,12 +342,12 @@ sub getMachines {
 
     for my $machinesFile (@machinesFiles) {
         next unless -e $machinesFile;
-        open CONF, "<$machinesFile" or die;
-        while (<CONF>) {
+        open my $conf, "<$machinesFile" or die;
+        while (my $line = <$conf>) {
             chomp;
             s/\#.*$//g;
             next if /^\s*$/;
-            my @tokens = split /\s/, $_;
+            my @tokens = split /\s/, $line;
             my @supportedFeatures = split(/,/, $tokens[5] || "");
             my @mandatoryFeatures = split(/,/, $tokens[6] || "");
             $machines{$tokens[0]} =
@@ -357,7 +359,7 @@ sub getMachines {
                 , mandatoryFeatures => [ @mandatoryFeatures ]
                 };
         }
-        close CONF;
+        close $conf;
     }
 
     return \%machines;

src/lib/Hydra/Model/DB.pm

@@ -1,6 +1,7 @@
 package Hydra::Model::DB;
 
 use strict;
+use warnings;
 use base 'Catalyst::Model::DBIC::Schema';
 
 sub getHydraPath {

src/lib/Hydra/Plugin.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin;
 
 use strict;
+use warnings;
 use Module::Pluggable
     search_path => "Hydra::Plugin",
     instantiate => 'new';

src/lib/Hydra/Plugin/BazaarInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::BazaarInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/BitBucketPulls.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::BitBucketPulls;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/BitBucketStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::BitBucketStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use JSON;

src/lib/Hydra/Plugin/CircleCINotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::CircleCINotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/CompressLog.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::CompressLog;
 
 use strict;
+use warnings;
 use utf8;
 use parent 'Hydra::Plugin';
 use Hydra::Helper::CatalystUtils;

src/lib/Hydra/Plugin/CoverityScan.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::CoverityScan;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use File::Basename;
 use LWP::UserAgent;
@@ -51,12 +52,12 @@ sub buildFinished {
     my $tarballs  = "$storePath/tarballs";
     my $covTarball;
 
-    opendir TARBALLS, $tarballs or die;
-    while (readdir TARBALLS) {
-        next unless $_ =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;
-        $covTarball = "$tarballs/$_"; last;
+    opendir my $tarballs_handle, $tarballs or die;
+    while (my $file = readdir $tarballshandle) {
+        next unless $file =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;
+        $covTarball = "$tarballs/$file"; last;
     }
-    closedir TARBALLS;
+    closedir $tarballs_handle;
 
     unless (defined $covTarball) {
         print STDERR "CoverityScan.pm: Coverity tarball not found in $tarballs; skipping upload...\n";
@@ -81,7 +82,8 @@ sub buildFinished {
     my $versionRE = "(?:[A-Za-z0-9\.\-]+)";
 
     my $shortName = basename($covTarball);
-    my $version = $2 if $shortName =~ /^($pkgNameRE)-($versionRE)-coverity-int.*$/;
+    my $version;
+    $version = $2 if $shortName =~ /^($pkgNameRE)-($versionRE)-coverity-int.*$/;
 
     die "CoverityScan.pm: Couldn't parse build version for upload! ($shortName)"
         unless defined $version;

src/lib/Hydra/Plugin/DarcsInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::DarcsInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/DeclarativeJobsets.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::DeclarativeJobsets;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Hydra::Helper::AddBuilds;
 

src/lib/Hydra/Plugin/EmailNotification.pm

@@ -2,6 +2,7 @@ package Hydra::Plugin::EmailNotification;
 
 use utf8;
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use POSIX qw(strftime);
 use Template;

src/lib/Hydra/Plugin/GitInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GitInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/GiteaStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GiteaStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 
 use HTTP::Request;

src/lib/Hydra/Plugin/GithubPulls.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GithubPulls;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/GithubRefs.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GithubRefs;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/GithubStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GithubStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use JSON;

src/lib/Hydra/Plugin/GitlabPulls.pm

@@ -15,6 +15,7 @@
 package Hydra::Plugin::GitlabPulls;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/GitlabStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GitlabStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use JSON;

src/lib/Hydra/Plugin/HipChatNotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::HipChatNotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use LWP::UserAgent;
 use Hydra::Helper::CatalystUtils;

src/lib/Hydra/Plugin/InfluxDBNotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::InfluxDBNotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/MercurialInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::MercurialInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/PathInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::PathInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use POSIX qw(strftime);
 use Hydra::Helper::Nix;

src/lib/Hydra/Plugin/RunCommand.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::RunCommand;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use experimental 'smartmatch';
 use JSON;

src/lib/Hydra/Plugin/S3Backup.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::S3Backup;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use File::Temp;
 use File::Basename;

src/lib/Hydra/Plugin/SlackNotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::SlackNotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/SoTest.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::SoTest;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Hydra::Helper::CatalystUtils;
 use HTTP::Request;
@@ -101,8 +102,8 @@ sub buildFinished {
     open( $authfile, "<", $sotest->{authfile} )
       or die "Cannot open Sotest authfile \${\$sotest->{authfile}}";
 
-    while (<$authfile>) {
-        if ( $_ =~ /(.+):(.+)/m ) {
+    while (my $line = <$authfile>) {
+        if ( $line =~ /(.+):(.+)/m ) {
             $sotest_username = $1;
             $sotest_password = $2;
         }

src/lib/Hydra/Plugin/SubversionInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::SubversionInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use Hydra::Helper::Nix;

src/lib/Hydra/View/JSON.pm

@@ -1,3 +1,5 @@
 package Hydra::View::JSON;
+use strict;
+use warnings;
 use base qw(Catalyst::View::JSON);
 1;

src/lib/Hydra/View/NARInfo.pm

@@ -1,5 +1,7 @@
 package Hydra::View::NARInfo;
 
+use strict;
+use warnings;
 use File::Basename;
 use Hydra::Helper::CatalystUtils;
 use MIME::Base64;
@@ -7,7 +9,6 @@ use Nix::Manifest;
 use Nix::Store;
 use Nix::Utils;
 use base qw/Catalyst::View/;
-use strict;
 
 sub process {
     my ($self, $c) = @_;

src/lib/Hydra/View/NixClosure.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixClosure;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use IO::Pipe;
 

src/lib/Hydra/View/NixExprs.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixExprs;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::Nix;
 use Hydra::Helper::Escape;

src/lib/Hydra/View/NixLog.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixLog;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::CatalystUtils;
 

src/lib/Hydra/View/NixManifest.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixManifest;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::Nix;
 use Nix::Store;

src/lib/Hydra/View/NixNAR.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixNAR;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::CatalystUtils;
 

src/lib/Hydra/View/TT.pm

@@ -1,6 +1,7 @@
 package Hydra::View::TT;
 
 use strict;
+use warnings;
 use base 'Catalyst::View::TT';
 use Hydra::Helper::Nix;
 use Time::Seconds;