Merge pull request #1003 from DeterminateSystems/perlcritic-level-4

perlcritic: level 4

t/Config/hydra-notify.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(hydra_config => q|

t/Config/include.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(

t/Config/statsd.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(hydra_config => q|

t/Controller/Build/evals.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 my %ctx = test_init();

t/Controller/Jobset/channel.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use IO::Uncompress::Bunzip2 qw(bunzip2);
 use Archive::Tar;

t/Controller/Jobset/evals.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 my %ctx = test_init();

t/Controller/Jobset/http.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use JSON qw(decode_json encode_json);
 

t/Controller/Jobset/type-constraints.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 my %ctx = test_init();
 

t/Controller/Root/evals.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 my %ctx = test_init();

t/Controller/metrics.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use JSON qw(decode_json encode_json);
 

t/Controller/projects.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use JSON qw(decode_json encode_json);
 

t/Event.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Hydra::Event;
 
 use Test2::V0;

t/Event/BuildFinished.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Event/BuildStarted.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Event/StepFinished.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Helper/escape.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 use Test2::V0;

t/PostgresListener.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Schema/Users.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/api-test.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use JSON;
 use File::Copy;

t/build-products.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/evaluate-basic.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/evaluate-dependent-jobsets.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/input-types/bzr-checkout.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/bzr.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/darcs.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/deepgit.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/git-rev.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/git.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/hg.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/svn-checkout.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/svn.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/lib/Setup.pm

@@ -1,6 +1,7 @@
 package Setup;
 
 use strict;
+use warnings;
 use Exporter;
 use Test::PostgreSQL;
 use File::Temp;
@@ -49,7 +50,7 @@ sub test_init {
     $ENV{'NIX_CONF_DIR'} = "$dir/nix/etc/nix";
     make_path($ENV{'NIX_CONF_DIR'});
     my $nixconf = "$ENV{'NIX_CONF_DIR'}/nix.conf";
-    my $nix_config = "sandbox = false\n" . $opts{'nix_config'};
+    my $nix_config = "sandbox = false\n" . ($opts{'nix_config'} || "");
     write_file($nixconf, $nix_config);
     $ENV{'HYDRA_CONFIG'} = "$dir/hydra.conf";
 

t/queue-runner/default-machine-file.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(

t/s3-backup-test.pl

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use File::Basename;
 use Hydra::Model::DB;
 use Hydra::Helper::Nix;
@@ -38,12 +39,12 @@ ok(-e "/tmp/s3/hydra/$successful_hash.nar", "The nar of a build that's a root is
 ok(-e "/tmp/s3/hydra/$successful_hash.narinfo", "The narinfo of a build that's a root is not removed by gc");
 
 my $gcRootsDir = getGCRootsDir;
-opendir DIR, $gcRootsDir or die;
-while(readdir DIR) {
-    next if $_ eq "." or $_ eq "..";
-    unlink "$gcRootsDir/$_";
+opendir my $dir, $gcRootsDir or die;
+while(my $file = readdir $dir) {
+    next if $file eq "." or $file eq "..";
+    unlink "$gcRootsDir/$file";
 }
-closedir DIR;
+closedir $dir;
 system("hydra-s3-backup-collect-garbage");
 ok(not -e "/tmp/s3/hydra/$successful_hash.nar", "The nar of a build that's not a root is removed by gc");
 ok(not -e "/tmp/s3/hydra/$successful_hash.narinfo", "The narinfo of a build that's not a root is removed by gc");

t/scripts/hydra-create-user.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/scripts/hydra-init.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/scripts/hydra-send-stats.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/setup-notifications-jobset.pl

@@ -1,3 +1,5 @@
+use strict;
+use warnings;
 use LWP::UserAgent;
 use JSON;