Tests: build-products: use is for good errors on failures
				
					
				
			This commit is contained in:
		@@ -18,21 +18,26 @@ hydra_setup($db);
 | 
			
		||||
my $jobset = createBaseJobset("build-products", "build-products.nix");
 | 
			
		||||
 | 
			
		||||
ok(evalSucceeds($jobset),               "Evaluating jobs/build-products.nix should exit with return code 0");
 | 
			
		||||
ok(nrQueuedBuildsForJobset($jobset) == 2 , "Evaluating jobs/build-products.nix should result in 2 builds");
 | 
			
		||||
is(nrQueuedBuildsForJobset($jobset), 2, "Evaluating jobs/build-products.nix should result in 2 builds");
 | 
			
		||||
 | 
			
		||||
for my $build (queuedBuildsForJobset($jobset)) {
 | 
			
		||||
    ok(runBuild($build), "Build '".$build->job."' from jobs/build-products.nix should exit with code 0");
 | 
			
		||||
    subtest "For the build job '" . $build->job . "'" => sub {
 | 
			
		||||
        ok(runBuild($build), "Build should exit with code 0");
 | 
			
		||||
        my $newbuild = $db->resultset('Builds')->find($build->id);
 | 
			
		||||
    ok($newbuild->finished == 1 && $newbuild->buildstatus == 0, "Build '".$build->job."' from jobs/build-products.nix should have buildstatus 0");
 | 
			
		||||
 | 
			
		||||
        is($newbuild->finished, 1, "Build should have finished");
 | 
			
		||||
        is($newbuild->buildstatus, 0, "Build should have buildstatus 0");
 | 
			
		||||
 | 
			
		||||
        my $buildproducts = $db->resultset('BuildProducts')->search({ build => $build->id });
 | 
			
		||||
        my $buildproduct = $buildproducts->next;
 | 
			
		||||
 | 
			
		||||
        if($build->job eq "simple") {
 | 
			
		||||
        ok($buildproduct->name eq "text.txt", "We should have text.txt, but found: ".$buildproduct->name."\n");
 | 
			
		||||
            is($buildproduct->name, "text.txt", "We should have \"text.txt\"");
 | 
			
		||||
        } elsif ($build->job eq "with_spaces") {
 | 
			
		||||
        ok($buildproduct->name eq "some text.txt", "We should have: \"some text.txt\", but found: ".$buildproduct->name."\n");
 | 
			
		||||
            is($buildproduct->name, "some text.txt", "We should have: \"some text.txt\"");
 | 
			
		||||
        }
 | 
			
		||||
    };
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
done_testing;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user