ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Merge pull request #927 from cole-h/nonexistent-user-400

Browse Source 
Return HTTP 400 when creating Project with nonexistent user
This commit is contained in:
Graham Christensen
2021-04-26 14:40:15 -04:00
committed by GitHub
parent bc292db45b 47e19ba22c
commit 453b8479be
3 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/Hydra/Controller/Project.pm
View File

@ -136,7 +136,7 @@ sub updateProject {
my $owner = $project->owner;
if ($c->check_user_roles('admin') and defined $c->stash->{params}->{owner}) {
$owner = trim $c->stash->{params}->{owner};
error($c, "The user name ‘$owner’ does not exist.")
badRequest($c, "The user name ‘$owner’ does not exist.")
unless defined $c->model('DB::Users')->find($owner);
}

6
src/lib/Hydra/Helper/CatalystUtils.pm
View File

@ -11,7 +11,7 @@ our @ISA = qw(Exporter);
our @EXPORT = qw(
getBuild getPreviousBuild getNextBuild getPreviousSuccessfulBuild
searchBuildsAndEvalsForJobset
error notFound gone accessDenied
error notFound gone accessDenied badRequest
forceLogin requireUser requireProjectOwner requireRestartPrivileges requireAdmin requirePost isAdmin isProjectOwner
requireBumpPrivileges
requireCancelBuildPrivileges
@ -155,6 +155,10 @@ sub accessDenied {
error($c, $msg, 403);
}
sub badRequest {
my ($c, $msg) = @_;
error($c, $msg, 400);
}
sub backToReferer {
my ($c) = @_;