hydra-queue-runner: Validate metric type

2025-08-02 15:17:35 +02:00
parent 8f3fdc14d8
commit 5014274c99
1 changed files with 5 additions and 1 deletions
--- a/src/hydra-queue-runner/build-result.cc
+++ b/src/hydra-queue-runner/build-result.cc
@@ -147,7 +147,11 @@ BuildOutput getBuildOutput(
                continue;
            BuildMetric metric;
            metric.name = fields[0];
-            metric.value = atof(fields[1].c_str()); // FIXME
+            try {
+                metric.value = std::stod(fields[1]);
+            } catch (...) {
+                continue; // skip this metric
+            }
            metric.unit = fields.size() >= 3 ? fields[2] : "";
            if (!std::regex_match(metric.unit, std::regex("[a-zA-Z0-9._%-]+")))
                metric.unit = "";