ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

hydra-queue-runner: Validate metric type

Browse Source
This commit is contained in:
Janne Heß
2025-08-02 15:17:35 +02:00
committed by ahuston-0
parent 8f3fdc14d8
commit 5014274c99
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/hydra-queue-runner/build-result.cc
View File

@@ -147,7 +147,11 @@ BuildOutput getBuildOutput(
continue; continue;
BuildMetric metric; BuildMetric metric;
metric.name = fields[0]; metric.name = fields[0];
metric.value = atof(fields[1].c_str()); // FIXME try {
metric.value = std::stod(fields[1]);
} catch (...) {
continue; // skip this metric
}
metric.unit = fields.size() >= 3 ? fields[2] : ""; metric.unit = fields.size() >= 3 ? fields[2] : "";
if (!std::regex_match(metric.unit, std::regex("[a-zA-Z0-9._%-]+"))) if (!std::regex_match(metric.unit, std::regex("[a-zA-Z0-9._%-]+")))
metric.unit = ""; metric.unit = "";