ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

eval_added event: change interface to traceID\tjobsetID\tevaluationID

Browse Source 
I was not going to break the interface until I noticed
the current implementation uses the string literal \t.
This commit is contained in:
Graham Christensen
2022-02-07 15:40:17 -05:00
parent d512e6220f
commit 517dce285a
8 changed files with 194 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
t/scripts/hydra-eval-jobset/notifications.t
View File

@ -67,13 +67,18 @@ subtest "on the initial evaluation" => sub {
is($listener->block_for_messages(0)->()->{"channel"}, "build_queued", "expect 2/4 builds being queued");
is($listener->block_for_messages(0)->()->{"channel"}, "build_queued", "expect 3/4 builds being queued");
is($listener->block_for_messages(0)->()->{"channel"}, "build_queued", "expect 4/4 builds being queued");
is($listener->block_for_messages(0)->()->{"channel"}, "eval_added", "the evaluation has completed");
expectEvent($listener, "eval_added", sub {
is($_->{"jobset_id"}, $jobset->get_column('id'), "the jobset ID matches");
is($_->{"evaluation_id"}, $evaluation->get_column('id'), "the evaluation ID matches");
});
is($listener->block_for_messages(0)->()->{"channel"}, "builds_added", "new builds have been scheduled");
is($listener->block_for_messages(0)->(), undef, "there are no more messages from the evaluator");
};
subtest "on a subsequent, totally cached / unchanged evaluation" => sub {
ok(evalSucceeds($jobset), "evaluating for the second time");
my $evaluation = $builds->{"stable-job-queued"}->jobsetevals->first();
my $traceID;
expectEvent($listener, "eval_started", sub {
@ -103,7 +108,9 @@ subtest "on a fresh evaluation with changed sources" => sub {
$builds->{"stable-job-failing"}->discard_changes();
ok(evalSucceeds($builds->{"variable-job"}->jobset), "evaluating for the third time");
is($listener->block_for_messages(0)->()->{"channel"}, "eval_started", "the evaluation started");
expectEvent($listener, "eval_started", sub {
is($_->{"jobset_id"}, $jobset->get_column('id'), "the jobset ID matches");
});
# The order of builds is randomized when writing to the database,
# so we can't expect the list in any specific order here.