ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

perlcritic: make all open() calls three-argument

Browse Source 
Two-argument calls end up parsing the second argument to guess what
should happen, three-arg parses ... less?
This commit is contained in:
Graham Christensen
2021-10-19 22:37:17 -04:00
parent 43c056bb7b
commit 7095d00608
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/Hydra/Helper/Nix.pm
View File

@ -141,7 +141,7 @@ sub registerRoot {
my ($path) = @_;
my $link = gcRootFor $path;
return if -e $link;
open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";
open(my $root, ">", $link) or die "cannot create GC root `$link' to `$path'";
close $root;
}
@ -342,7 +342,7 @@ sub getMachines {
for my $machinesFile (@machinesFiles) {
next unless -e $machinesFile;
open my $conf, "<$machinesFile" or die;
open(my $conf, "<", $machinesFile) or die;
while (my $line = <$conf>) {
chomp;
s/\#.*$//g;