ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

perlcritic: make all open() calls three-argument

Browse Source 
Two-argument calls end up parsing the second argument to guess what
should happen, three-arg parses ... less?
This commit is contained in:
Graham Christensen
2021-10-19 22:37:17 -04:00
parent 43c056bb7b
commit 7095d00608
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/Hydra/View/NixClosure.pm
View File

@ -14,7 +14,7 @@ sub process {
my $fh = IO::Handle->new();
open $fh, "nix-store --export `nix-store -qR @storePaths` | gzip |";
open($fh, "-|", "nix-store --export `nix-store -qR @storePaths` | gzip");
$c->response->body($fh);

8
src/lib/Hydra/View/NixLog.pm
View File

@ -17,13 +17,13 @@ sub process {
my $tail = int($c->stash->{tail} // "0");
if ($logPath =~ /\.bz2$/) {
my $doTail = $tail ? " tail -n '$tail' |" : "";
open $fh, "bzip2 -dc < '$logPath' | $doTail" or die;
my $doTail = $tail ? "| tail -n '$tail'" : "";
open($fh, "-|", "bzip2 -dc < '$logPath' $doTail") or die;
} else {
if ($tail) {
open $fh, "tail -n '$tail' '$logPath' |" or die;
open($fh, "-|", "tail -n '$tail' '$logPath'") or die;
} else {
open $fh, "<$logPath" or die;
open($fh, "<", $logPath) or die;
}
}
binmode($fh);

2
src/lib/Hydra/View/NixNAR.pm
View File

@ -16,7 +16,7 @@ sub process {
my $fh = IO::Handle->new();
open $fh, "nix-store --dump '$storePath' | pixz -0 $pParam |";
open($fh, "-|", "nix-store --dump '$storePath' | pixz -0 $pParam");
setCacheHeaders($c, 365 * 24 * 60 * 60);