perlcritic: explicitly assign the result of readdir/file reads

This commit is contained in:
Graham Christensen
2021-09-07 21:53:07 -04:00
parent 85bb1c7ef9
commit 741590c923
4 changed files with 10 additions and 10 deletions

View File

@ -53,9 +53,9 @@ sub buildFinished {
my $covTarball;
opendir my $tarballs_handle, $tarballs or die;
while (readdir $tarballshandle) {
next unless $_ =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;
$covTarball = "$tarballs/$_"; last;
while (my $file = readdir $tarballshandle) {
next unless $file =~ /.*-coverity-int\.(tgz|lzma|xz|bz2|zip)$/;
$covTarball = "$tarballs/$file"; last;
}
closedir $tarballs_handle;

View File

@ -102,8 +102,8 @@ sub buildFinished {
open( $authfile, "<", $sotest->{authfile} )
or die "Cannot open Sotest authfile \${\$sotest->{authfile}}";
while (<$authfile>) {
if ( $_ =~ /(.+):(.+)/m ) {
while (my $line = <$authfile>) {
if ( $line =~ /(.+):(.+)/m ) {
$sotest_username = $1;
$sotest_password = $2;
}