From 74d923441e439542d9a5353226885ddbc53d344a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Janne=20He=C3=9F?= <janne@hess.ooo>
Date: Sat, 2 Aug 2025 15:07:25 +0200
Subject: [PATCH] hydra-queue-runner: Validate metric name in hydra-metrics

---
 src/hydra-queue-runner/build-result.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/hydra-queue-runner/build-result.cc b/src/hydra-queue-runner/build-result.cc
index a5dec9c5..937cdd94 100644
--- a/src/hydra-queue-runner/build-result.cc
+++ b/src/hydra-queue-runner/build-result.cc
@@ -143,8 +143,10 @@ BuildOutput getBuildOutput(
         for (auto & line : tokenizeString<Strings>(file->second.contents.value(), "\n")) {
             auto fields = tokenizeString<std::vector<std::string>>(line);
             if (fields.size() < 2) continue;
+            if (!std::regex_match(fields[0], std::regex("[a-zA-Z0-9._-]+")))
+                continue;
             BuildMetric metric;
-            metric.name = fields[0]; // FIXME: validate
+            metric.name = fields[0];
             metric.value = atof(fields[1].c_str()); // FIXME
             metric.unit = fields.size() >= 3 ? fields[2] : "";
             res.metrics[metric.name] = metric;