ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Optimise clickable rows

Browse Source 
Set a click handler on the table instead of on every row.  This should
be faster on large tables.  Also, it's easier to use: you just set the
clickable-rows class on the table, and the row-link class on the <a>
element that contains the "main" link of the row.
This commit is contained in:
Eelco Dolstra
2013-02-22 18:05:04 +01:00
parent bd7be1cb84
commit 9422c9d2a7
7 changed files with 34 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/root/build.tt
View File

@ -15,7 +15,7 @@
[% END %]
[% BLOCK renderBuildSteps %]
<table class="tablesorter table table-striped table-condensed">
<table class="tablesorter table table-striped table-condensed clickable-rows">
<thead>
<tr><th>Nr</th><th>What</th><th>Duration</th><th>Machine</th><th>Status</th></tr>
</thead>
@ -24,7 +24,7 @@
[% IF ( type == "All" ) || ( type == "Failed" && step.status != 0 ) || ( type == "Running" && step.busy == 1 ) %]
[% has_log = log_exists(step.drvpath);
log = c.uri_for('/build' build.id 'nixlog' step.stepnr); %]
<tr [% IF has_log %] onclick="window.location = '[% log %]'" [% END %]>
<tr>
<td>[% step.stepnr %]</td>
<td>
[% IF step.type == 0 %]
@ -53,7 +53,7 @@
[% ELSE %]
<span class="error">Failed: [% HTML.escape(step.errormsg) %]</span>
[% END %]
[%%] [%+ IF has_log; INCLUDE renderLogLinks url=log; END %]
[%%] [%+ IF has_log; INCLUDE renderLogLinks url=log inRow=1; END %]
</td>
</tr>
[% END %]