Warn against multiple jobs with the same name

2013-09-25 15:30:59 +02:00
parent da5824e11c
commit a8db329839
2 changed files with 11 additions and 3 deletions
--- a/src/lib/Hydra/Helper/AddBuilds.pm
+++ b/src/lib/Hydra/Helper/AddBuilds.pm
@ -282,7 +282,16 @@ sub evalJobs {
        SuppressEmpty => '')
        or die "cannot parse XML output";

-    return ($jobs, $nixExprInput);
+    my %jobNames;
+    my $errors;
+    foreach my $job (@{$jobs->{job}}) {
+        $jobNames{$job->{jobName}}++;
+        if ($jobNames{$job->{jobName}} == 2) {
+            $errors .= "warning: there are multiple jobs named ‘$job->{jobName}’; support for this will go away soon!\n\n";
+        }
+    }
+
+    return ($jobs, $nixExprInput, $errors);
 }