diff --git a/src/lib/Hydra/Controller/Jobset.pm b/src/lib/Hydra/Controller/Jobset.pm index b9da12ee..529a456b 100644 --- a/src/lib/Hydra/Controller/Jobset.pm +++ b/src/lib/Hydra/Controller/Jobset.pm @@ -163,7 +163,7 @@ sub edit : Chained('jobsetChain') PathPart Args(0) { $c->stash->{template} = 'edit-jobset.tt'; $c->stash->{edit} = 1; - $c->stash->{clone} = defined $c->stash->{params}->{clone}; + $c->stash->{cloneJobset} = defined $c->stash->{params}->{cloneJobset}; $c->stash->{totalShares} = getTotalShares($c->model('DB')->schema); } @@ -269,7 +269,7 @@ sub clone : Chained('jobsetChain') PathPart('clone') Args(0) { requireProjectOwner($c, $c->stash->{project}); $c->stash->{template} = 'edit-jobset.tt'; - $c->stash->{clone} = 1; + $c->stash->{cloneJobset} = 1; $c->stash->{totalShares} = getTotalShares($c->model('DB')->schema); } diff --git a/src/lib/Hydra/Controller/JobsetEval.pm b/src/lib/Hydra/Controller/JobsetEval.pm index 65ae7fb0..c7ea4448 100644 --- a/src/lib/Hydra/Controller/JobsetEval.pm +++ b/src/lib/Hydra/Controller/JobsetEval.pm @@ -157,6 +157,17 @@ sub release : Chained('eval') PathPart('release') Args(0) { } +sub create_jobset : Chained('eval') PathPart('create-jobset') Args(0) { + my ($self, $c) = @_; + my $eval = $c->stash->{eval}; + + requireProjectOwner($c, $c->stash->{project}); + + $c->stash->{template} = 'edit-jobset.tt'; + $c->stash->{createFromEval} = 1; +} + + sub cancel : Chained('eval') PathPart('cancel') Args(0) { my ($self, $c) = @_; requireProjectOwner($c, $c->stash->{eval}->project); diff --git a/src/lib/Hydra/Controller/Project.pm b/src/lib/Hydra/Controller/Project.pm index 1fea107b..4cd577b1 100644 --- a/src/lib/Hydra/Controller/Project.pm +++ b/src/lib/Hydra/Controller/Project.pm @@ -113,7 +113,6 @@ sub create : Path('/create-project') { $c->stash->{template} = 'edit-project.tt'; $c->stash->{create} = 1; - $c->stash->{edit} = 1; } @@ -124,7 +123,6 @@ sub create_jobset : Chained('projectChain') PathPart('create-jobset') Args(0) { $c->stash->{template} = 'edit-jobset.tt'; $c->stash->{create} = 1; - $c->stash->{edit} = 1; $c->stash->{totalShares} = getTotalShares($c->model('DB')->schema); } diff --git a/src/root/edit-jobset.tt b/src/root/edit-jobset.tt index 0fc06abe..30b9a4c9 100644 --- a/src/root/edit-jobset.tt +++ b/src/root/edit-jobset.tt @@ -1,4 +1,8 @@ -[% WRAPPER layout.tt title=(create ? "Create jobset in project $project.name" : clone ? "Cloning jobset $project.name:$jobset.name" : "Editing jobset $project.name:$jobset.name") %] +[% WRAPPER layout.tt title= + (create ? "Creating jobset in project $project.name" : + createFromEval ? "Creating jobset from evaluation $eval.id of $project.name:$jobset.name" : + cloneJobset ? "Cloning jobset $project.name:$jobset.name" : + "Editing jobset $project.name:$jobset.name") %] [% PROCESS common.tt %] [% USE format %] @@ -11,16 +15,25 @@ <input type="text" id="[% baseName %]-name" name="[% baseName %]-name" [% HTML.attributes(value => input.name) %]/> </td> <td> - [% INCLUDE renderSelection curValue=input.type param="$baseName-type" options=inputTypes %] + [% INCLUDE renderSelection curValue=input.type param="$baseName-type" options=inputTypes edit=1 %] </td> <td id="[% baseName %]"> - [% alt = input.search_related('jobsetinputalts', {altnr => 0}) %] - <input style="width: 95%" type="text" [% HTML.attributes(value => alt.value, id => "$baseName-value", name => "$baseName-value") %]/> - [% IF input.jobsetinputalts_rs.count > 1 %] + [% IF createFromEval %] + [% value = (input.uri or input.value); IF input.revision; value = value _ " " _ input.revision; END; + warn = input.altnr != 0; + %] + [% ELSE %] + [% alt = input.search_related('jobsetinputalts', {altnr => 0}); + value = alt.value + warn = input.jobsetinputalts_rs.count > 1; + %] + [% END %] + [% IF warn %] <div class="alert alert-warning">Warning: This input had more than one value. This is no longer supported. The additional values have been removed.</div> [% END %] + <input style="width: 95%" type="text" [% HTML.attributes(value => value, id => "$baseName-value", name => "$baseName-value") %]/> </td> <td> <input type="checkbox" id="[% baseName %]-emailresponsible" name="[% baseName %]-emailresponsible" [% IF input.emailresponsible; 'checked="checked"'; END %]/> @@ -34,7 +47,7 @@ <tr><th></th><th>Input name</th><th>Type</th><th style="width: 50%">Value</th><th>Notify committers</th></tr> </thead> <tbody class="inputs"> - [% FOREACH input IN jobset.jobsetinputs %] + [% inputs = createFromEval ? eval.jobsetevalinputs : jobset.jobsetinputs; FOREACH input IN inputs %] [% INCLUDE renderJobsetInput input=input baseName="input-$input.name" %] [% END %] <tr> @@ -71,7 +84,7 @@ <div class="control-group"> <label class="control-label">Identifier</label> <div class="controls"> - <input type="text" class="span3" name="name" [% HTML.attributes(value => clone ? "" : jobset.name) %]/> + <input type="text" class="span3" name="name" [% HTML.attributes(value => edit ? jobset.name : "") %]/> </div> </div> @@ -139,7 +152,7 @@ [% INCLUDE renderJobsetInputs %] <div class="form-actions"> - <button id="submit-jobset" type="submit" class="btn btn-primary"><i class="icon-ok icon-white"></i> [%IF create || clone %]Create jobset[% ELSE %]Apply changes[% END %]</button> + <button id="submit-jobset" type="submit" class="btn btn-primary"><i class="icon-ok icon-white"></i> [%IF !edit %]Create jobset[% ELSE %]Apply changes[% END %]</button> </div> </fieldset> @@ -191,7 +204,7 @@ } } redirectJSON({ - [% IF create || clone %] + [% IF !edit %] url: "[% c.uri_for('/jobset' project.name '.new') %]", [% ELSE %] url: "[% c.uri_for('/jobset' project.name jobset.name) %]", diff --git a/src/root/jobset-eval.tt b/src/root/jobset-eval.tt index fb587fc8..48b44e87 100644 --- a/src/root/jobset-eval.tt +++ b/src/root/jobset-eval.tt @@ -46,6 +46,7 @@ c.uri_for(c.controller('JobsetEval').action_for('view'), </a> <ul class="dropdown-menu"> <li><a href="[% c.uri_for(c.controller('JobsetEval').action_for('release'), [eval.id]) %]">Create a release from this evaluation</a></li> + <li><a href="[% c.uri_for(c.controller('JobsetEval').action_for('create_jobset'), [eval.id]) %]">Create a jobset from this evaluation</a></li> <li><a href="[% c.uri_for(c.controller('JobsetEval').action_for('cancel'), [eval.id]) %]">Cancel all scheduled builds</a></li> <li><a href="[% c.uri_for(c.controller('JobsetEval').action_for('restart_aborted'), [eval.id]) %]">Restart all aborted builds</a></li> </ul>