perlcritic: Don't conditionally declare variables

2021-09-07 21:35:01 -04:00
parent 21e1ff0da1
commit c603ae35f0
3 changed files with 8 additions and 4 deletions
--- a/src/lib/Hydra/Plugin/CoverityScan.pm
+++ b/src/lib/Hydra/Plugin/CoverityScan.pm
@ -82,7 +82,8 @@ sub buildFinished {
    my $versionRE = "(?:[A-Za-z0-9\.\-]+)";

    my $shortName = basename($covTarball);
-    my $version = $2 if $shortName =~ /^($pkgNameRE)-($versionRE)-coverity-int.*$/;
+    my $version;
+    $version = $2 if $shortName =~ /^($pkgNameRE)-($versionRE)-coverity-int.*$/;

    die "CoverityScan.pm: Couldn't parse build version for upload! ($shortName)"
        unless defined $version;