From f6fa2e16c0aa81b26ea4df949e81037479a64981 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= <joerg@thalheim.io>
Date: Sat, 13 Sep 2025 09:36:49 +0200
Subject: [PATCH] tests: Gitea test nitpicks

- Add proper waitpid() for child process cleanup
- Simplify file existence check loop with early exit
- Rename variables for clarity ($uri -> $request_uri, remove unused $i)
---
 t/Hydra/Plugin/gitea.t | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/t/Hydra/Plugin/gitea.t b/t/Hydra/Plugin/gitea.t
index 3de4ea8f..64f41429 100644
--- a/t/Hydra/Plugin/gitea.t
+++ b/t/Hydra/Plugin/gitea.t
@@ -58,24 +58,23 @@ if (!defined($pid = fork())) {
     ok(sendNotifications(), "Sent notifications");
 
     kill('INT', $pid);
+    waitpid($pid, 0);
 }
 
 # We expect $ctx{jobsdir}/server.py to create the file at $filename, but the time it
 # takes to do so is non-deterministic. We need to give it _some_ time to hopefully
 # settle -- but not too much that it drastically slows things down.
 for my $i (1..10) {
-    if (! -f $filename) {
-       diag("$filename does not yet exist");
-       sleep(1);
-    }
+    last if -f $filename;
+    diag("$filename does not yet exist");
+    sleep(1);
 }
 
 open(my $fh, "<", $filename) or die ("Can't open(): $!\n");
-my $i = 0;
-my $uri = <$fh>;
+my $request_uri = <$fh>;
 my $data = <$fh>;
 
-ok(index($uri, "gitea/api/v1/repos/root/foo/statuses") != -1, "Correct URL");
+ok(index($request_uri, "gitea/api/v1/repos/root/foo/statuses") != -1, "Correct URL");
 
 my $json = JSON->new;
 my $content;