ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

RunCommandLogs: identify and access via uuid

Browse Source 
Using a sha1 of the command combined with the build ID is not a
particularly good or unique identifier:

* A build could fail, be restarted, and then succeed -- assuming no
configuration changes, the sha1 hash of the command as well as the build
ID will be the same. This would lead to an overwritten log file.

* Allowing user input to influence filenames is not the best of ideas.
This commit is contained in:
Cole Helbling
2022-01-26 10:26:28 -08:00
parent dcb0c1425c
commit fc3cf4ecb2
6 changed files with 10 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/Hydra/Plugin/RunCommand.pm
View File

@ -163,8 +163,7 @@ sub buildFinished {
$runlog->started();
my $filename = Hydra::Helper::Nix::constructRunCommandLogFilename(sha1_hex($command), $build->get_column('id'));
my $logPath = Hydra::Helper::Nix::constructRunCommandLogPath($filename);
my $logPath = Hydra::Helper::Nix::constructRunCommandLogPath($runlog->uuid);
my $dir = dirname($logPath);
my $oldUmask = umask();