applies all recommended deadnix fixes, and adds it to checks

Signed-off-by: ahuston-0 <aliceghuston@gmail.com>

checks.nix

@@ -23,6 +23,15 @@ forEachSystem (system: {
       ## static analysis checks for nix
       nil.enable = true;
       statix.enable = true;
+      deadnix = {
+        enable = true;
+        settings = {
+          noUnderscore = true; # ignore variables starting with underscore
+          # ignore lambda patterns (useful for passing args from ({}@args)
+          # to other functions)
+          noLambdaPatternNames = true;
+        };
+      };
 
       # json hooks
       check-json = {

flake.nix

@@ -110,17 +110,7 @@
   };
 
   outputs =
-    {
+    { self, nixpkgs, ... }@inputs:
-      self,
-      nix,
-      home-manager,
-      nixos-hardware,
-      nixos-modules,
-      nixpkgs,
-      sops-nix,
-      wired-notify,
-      ...
-    }@inputs:
     let
       systems = [
         "x86_64-linux"
@@ -135,7 +125,7 @@
 
       # adds our lib functions to lib namespace
       lib = nixpkgs.lib.extend (
-        self: super:
+        self: _:
         import ./lib {
           inherit nixpkgs inputs;
           lib = self;

hydra/jobsets.nix

@@ -1,12 +1,5 @@
-{
+{ pulls, branches, ... }:
-  nixpkgs,
-  pulls,
-  branches,
-  ...
-}:
 let
-  pkgs = import nixpkgs { };
-
   # create the json spec for the jobset
   makeSpec =
     contents:

lib/default.nix

@@ -44,7 +44,7 @@
     lsdir =
       dir:
       lib.optionals (builtins.pathExists dir) (
-        lib.attrNames (lib.filterAttrs (path: type: type == "directory") (builtins.readDir dir))
+        lib.attrNames (lib.filterAttrs (_: type: type == "directory") (builtins.readDir dir))
       );
 
     # return full paths of all files in a directory

lib/systems.nix

@@ -69,8 +69,8 @@ rec {
     user: src:
     {
       config,
-      lib,
       pkgs,
+      lib,
       ...
     }@args:
     {
@@ -153,7 +153,7 @@ rec {
       users,
       home ? true,
       modules ? [ ],
-      server ? true,
+      # server ? true,
       sops ? true,
       system ? "x86_64-linux",
     }@args:

modules/autopull.nix

@@ -66,7 +66,7 @@ in
         ];
 
       systemd.services = lib.mapAttrs' (
-        repo:
+        _:
         {
           repo-name,
           ssh-key,
@@ -90,7 +90,7 @@ in
       ) repos;
 
       systemd.timers = lib.mapAttrs' (
-        repo:
+        _:
         { repo-name, frequency, ... }:
         lib.nameValuePair "autopull@${repo-name}" {
           wantedBy = [ "timers.target" ];

systems/artemision/audio.nix

@@ -1,9 +1,4 @@
-{
+{ pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   # rtkit is optional but recommended

systems/artemision/desktop.nix

@@ -1,9 +1,4 @@
-{
+{ pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   # installs hyprland, and its dependencies

systems/artemision/fingerprint.nix

@@ -1,9 +1,4 @@
-{
+{ pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 {
   # custom module from modules/pam-fingerprint-swap.nix
   # swaps password and fingerprint in pam ordering

systems/artemision/graphics.nix

@@ -1,9 +1,4 @@
-{
+{ pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   hardware.opengl = {

systems/artemision/polkit.nix

@@ -1,9 +1,4 @@
-{
+{ pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   security.polkit.enable = true;

systems/artemision/steam.nix

@@ -1,9 +1,4 @@
-{
+{ pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   environment.systemPackages = [ pkgs.steam-run ];

systems/jeeves/hardware.nix

@@ -4,7 +4,6 @@
 {
   config,
   lib,
-  pkgs,
   modulesPath,
   ...
 }:

systems/palatine-hill/configuration.nix

@@ -5,12 +5,6 @@
   ...
 }:
 let
-  keygen = key: {
-    format = "binary";
-    sopsFile = ./keys/${key};
-    mode = "0400";
-    path = "/crypto/keys/${key}";
-  };
   bootkey = key: { "/crypto/keys/${key}" = /crypto/keys/${key}; };
   zfskeys = [
     "zfs-attic-key"

systems/rhapsody-in-green/hardware.nix

@@ -4,7 +4,6 @@
 {
   config,
   lib,
-  pkgs,
   modulesPath,
   ...
 }:

users/alice/home/doom/default.nix

@@ -1,9 +1,4 @@
-{
+{ ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   xdg.configFile = {

users/alice/home/git.nix

@@ -1,9 +1,4 @@
-{
+{ ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   programs.git = {

users/alice/home/waybar.nix

@@ -1,9 +1,4 @@
-{
+{ ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 {
   programs.waybar = {

users/alice/home/zsh.nix

@@ -1,4 +1,4 @@
-{ pkgs, ... }:
+{ ... }:
 {
 
   programs.zsh = {