ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

hydra-queue-runner: Validate metric name in hydra-metrics

Browse Source
This commit is contained in:
Janne Heß
2025-08-02 15:07:25 +02:00
committed by ahuston-0
parent 9396846892
commit 74d923441e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/hydra-queue-runner/build-result.cc
View File

@@ -143,8 +143,10 @@ BuildOutput getBuildOutput(
for (auto & line : tokenizeString<Strings>(file->second.contents.value(), "\n")) { for (auto & line : tokenizeString<Strings>(file->second.contents.value(), "\n")) {
auto fields = tokenizeString<std::vector<std::string>>(line); auto fields = tokenizeString<std::vector<std::string>>(line);
if (fields.size() < 2) continue; if (fields.size() < 2) continue;
if (!std::regex_match(fields[0], std::regex("[a-zA-Z0-9._-]+")))
continue;
BuildMetric metric; BuildMetric metric;
metric.name = fields[0]; // FIXME: validate metric.name = fields[0];
metric.value = atof(fields[1].c_str()); // FIXME metric.value = atof(fields[1].c_str()); // FIXME
metric.unit = fields.size() >= 3 ? fields[2] : ""; metric.unit = fields.size() >= 3 ? fields[2] : "";
res.metrics[metric.name] = metric; res.metrics[metric.name] = metric;