ahuston-0/hydra
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

tests: Gitea test nitpicks

Browse Source 
- Add proper waitpid() for child process cleanup
- Simplify file existence check loop with early exit
- Rename variables for clarity ($uri -> $request_uri, remove unused $i)
This commit is contained in:
Jörg Thalheim
2025-09-13 09:36:49 +02:00
committed by ahuston-0
parent db6fcabbf3
commit f6fa2e16c0
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
t/Hydra/Plugin/gitea.t
View File

@@ -58,24 +58,23 @@ if (!defined($pid = fork())) {
ok(sendNotifications(), "Sent notifications"); ok(sendNotifications(), "Sent notifications");
kill('INT', $pid); kill('INT', $pid);
waitpid($pid, 0);
} }
# We expect $ctx{jobsdir}/server.py to create the file at $filename, but the time it # We expect $ctx{jobsdir}/server.py to create the file at $filename, but the time it
# takes to do so is non-deterministic. We need to give it _some_ time to hopefully # takes to do so is non-deterministic. We need to give it _some_ time to hopefully
# settle -- but not too much that it drastically slows things down. # settle -- but not too much that it drastically slows things down.
for my $i (1..10) { for my $i (1..10) {
if (! -f $filename) { last if -f $filename;
diag("$filename does not yet exist"); diag("$filename does not yet exist");
sleep(1); sleep(1);
}
} }
open(my $fh, "<", $filename) or die ("Can't open(): $!\n"); open(my $fh, "<", $filename) or die ("Can't open(): $!\n");
my $i = 0; my $request_uri = <$fh>;
my $uri = <$fh>;
my $data = <$fh>; my $data = <$fh>;
ok(index($uri, "gitea/api/v1/repos/root/foo/statuses") != -1, "Correct URL"); ok(index($request_uri, "gitea/api/v1/repos/root/foo/statuses") != -1, "Correct URL");
my $json = JSON->new; my $json = JSON->new;
my $content; my $content;